fix incorrect parsing of names for custom csr registers #1176
Conversation
aap-sc
force-pushed
the
aap-sc/csr_as_hex_regression_fixup
branch
from
6280641 to
093b63f
Compare
this commit fixes a regression introduced in ba8c1ee. The regression was caused by removal of these lines: ``` - /* Register prefix: "csr_" or "custom_" */ - strcpy(name, reg_type); - name[strlen(reg_type)] = '_'; ``` causing all CSR names with custom names to be parsed as empty strings.
aap-sc
force-pushed
the
aap-sc/csr_as_hex_regression_fixup
branch
from
093b63f to
109646c
Compare
|
@JanMatCodasip , @en-sc take a look please. This commit should fix a regression, please see commit description |
@JanMatCodasip to my surprise there are tests that should catch this issue. I don't understand why these tests passed. The regression is definitely there. Looks like something is wrong with testing - I'm trying to figure things out. |
Ok, I figured things out. No, there are not such tests. To trigger the issue you have to have something like this in your configuration file: That is you have to specify a name for the exposed register. We have no such constructs in the configuration files used in riscv-tests. I'll add those shortly (once this change is merged in) |
this commit fixes a regression introduced in
ba8c1ee.
The regression was caused by removal of these lines:
causing all CSR names with custom names to be parsed as empty strings.